Open
Conversation
SnickerdoodleCTO
previously approved these changes
Aug 2, 2023
SnickerChar
requested changes
Aug 3, 2023
Contributor
SnickerChar
left a comment
SnickerChar
left a comment
There was a problem hiding this comment.
Can you do a cleanup round on this? Just to make it combine better with the monorepo.
| @@ -0,0 +1,283 @@ | |||
| module.exports = { | |||
Contributor
There was a problem hiding this comment.
Why is this eslint so different from the other .eslint? Is that a react native thing?
packages/mobile-nodeify/.gitignore
Outdated
Contributor
There was a problem hiding this comment.
Shouldn't need a separate .gitignore; the one at the root should suffice.
packages/mobile-nodeify/package.json
Outdated
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "name": "sd-nodeify", | |||
| }, | ||
| "version": "1.0.10", | ||
| "preferGlobal": true, | ||
| "bin": { |
Contributor
There was a problem hiding this comment.
bin? shouldn't this be scripts?
| "precommit": "npm run lint" | ||
| }, | ||
| "devDependencies": { | ||
| "husky": "^0.14.3" |
Contributor
There was a problem hiding this comment.
All devDependencies should be in the root
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "compilerOptions": { | |||
Contributor
There was a problem hiding this comment.
this tsconfig doesn't look anything like the others and there's no TS in the project, you should probably nuke this.
- Neccessary dependencies added to coreList - Project name updated to @snickerdoodlelabs/mobile-nodeify - Versions of the dependencies a little bit changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
JIRA Link
Summary:
Give a brief summary of what your change is and why it is required.
Intended results:
Potential Failures:
Relevant Metrics/Indicators:
Testing Notes:
Pre-Flight Checks