Merged
Conversation
Added routes for compare/restore/remove operations on the deployed resources Included routes for override handling during the evaluation process Updated existing routes to reflect current set of possible response codes and changed payloads or returned structures Removing obsolete /version route
pasha-zayko
changed the title
Updating Get call to include another property being returned Adding Patch call for the tag handling and extra resource provisioning
… to list records Compare and Compare/Invoke endpoints now return data as arrays instead of objects with dynamic property names
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Shield API routes to reflect the new Deploy V3 process architecture, expanding the deployment functionality from basic infrastructure deployment to a comprehensive resource management system.
- Updates existing /Api/Deploy endpoint with new status codes and enhanced request/response structures
- Adds new endpoints for architecture management, resource evaluation, restoration, removal, and skip rule handling
- Removes obsolete /Api/Deploy/Version endpoint and updates several endpoint summaries for consistency
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shield/TypeScript/package.json | Version bump from 3.0.4 to 3.0.5 |
| specs/SHIELD.json | Major API specification update adding new Deploy V3 schemas, endpoints, and restructuring existing deployment routes |
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
Thanks copilot
Adding new endpoint to handle requests for list of configuration items Adjusting path on the request for the list of architectures
Properties describing used plugins are not needed
elliot-huffman
changed the title
elliot-huffman
requested changes
Oct 9, 2025
Contributor
elliot-huffman
left a comment
elliot-huffman
left a comment
There was a problem hiding this comment.
Please update to OpenAPI 3.1 as seen on the main branch. Thanks!
Enhanced information presentation with elements expected in OpenApi spec v3.1
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
elliot-huffman
approved these changes
Oct 14, 2025
Contributor
elliot-huffman
left a comment
elliot-huffman
left a comment
There was a problem hiding this comment.
After fixes, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy v3 update