Closed
Conversation
Adding API endpoints to describe: - operation to run an evaluation and provide results - operation to record a item to be skipped - operation to remove reference to skipped - operation to restore value for entire item or single property
Contributor
|
once Delta engine is merged in SHIELD, I will review this. |
Updating endpoints to reflect new schema. Enhancing descriptions for clarity and to include relevant information. Adding new endpoint definition.
Split operation into 2 endpoints with different behavior for the existing one Extract common response object
Ensure capitalization is applied
elliot-huffman
requested changes
Apr 22, 2025
Contributor
elliot-huffman
left a comment
elliot-huffman
left a comment
There was a problem hiding this comment.
Please check data types.
| "type": "object", | ||
| "properties": { | ||
| "invalid": { | ||
| "additionalProperties": { |
Contributor
There was a problem hiding this comment.
The API doesn't respond with this set of data. Additional properties are only present on Kiota client parsing. The server sends the data normally.
elliot-huffman
requested changes
Apr 22, 2025
specs/SHIELD.json
Outdated
| "title": "Type of security class the object(s) belongs to", | ||
| "type": "string" | ||
| }, | ||
| "Shield.Deploy.Delta.Response": { |
Contributor
There was a problem hiding this comment.
The name is not clear enough. The name should be something like DeltaStatus or DeltaState. All API responses are responses. This is begging the question.
Changes in response to review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding API endpoints to describe: