Show thumbnail image in edit view if baseUrl is set in opts #59
Open
ddresch wants to merge 5 commits intoSoftwareBrothers:masterfrom
Open
Show thumbnail image in edit view if baseUrl is set in opts #59ddresch wants to merge 5 commits intoSoftwareBrothers:masterfrom
ddresch wants to merge 5 commits intoSoftwareBrothers:masterfrom
Conversation
Author
|
The merge is up-to-date with the latest version incl. V7 updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, the edit view is not displaying uploaded images in the dropzone, which is ignoring the opts parameter. With a set
baseUrl(e.g. '/files') you end up with URLs like this:This PR adds the needed check if baseUrl is defined in the opts object.
Additionally (sorry mixed it up with this PR) a quick check is added if a property is really set when doing the update of the
docobject in the update process.