Allow compatibility with Netty 4.1.x#13
Closed
ladrl wants to merge 1 commit intoSolarNetwork:mainfrom
Closed
Conversation
This requires the server to have protected factory methods for the event groups that default to the 4.1.x `NioEventLoopGroup`. The client also requires such a factory method.
Author
|
I was able to use your library as is. The problem was a missing dependency to the new |
Contributor
|
Hey @ladrl just checking, were you trying that new feature branch I mentioned, or are you saying you're able to just use the existing release in your project? I am interested in feedback on the feature branch, if you did try it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires the server to have protected factory methods for the event groups that default to the 4.1.x
NioEventLoopGroup. The client also requires such a factory method.Closes #12