Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure newly created Solid preferences resources are populated with default triples (and corresponding type index resources are created), instead of leaving the Preferences.ttl document blank.
Changes:
- Add logic in
profileLogic.loadPreferences()to ensure the preferences document exists and (conditionally) initialize default preferences/type-index statements. - Add defaults initialization that inserts
space:ConfigurationFile, a title, and links to public/private type indexes, and creates the index docs if missing. - Update profile logic tests to assert the additional PATCH/PUT requests for populating Preferences.ttl and creating type index files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/profile/profileLogic.ts |
Adds preferences initialization and doc-existence handling during loadPreferences() to populate defaults and create type index docs. |
test/profileLogic.test.ts |
Updates tests to validate PATCH contents for Preferences.ttl and presence of PUTs for preferences/type index resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
created a new branch. |
The preference file, public type index, and private type index that were getting created were blank, this populates the files as done in the server upon registration for a new account. The Preferences file that was being created also was named Preferences.ttl, while the server creates prefs.ttl so that was also changed to match.
Lastly if the preferences file is missing it also looks for the public and private type indexes. The public type index is written to the webid profile as well as the prefs file, while the private index is only written to prefs as the specification indicates.