Skip to content

ECHOES-1265 Update sidebar navigation (padding, header, accordion)#657

Open
marciopmoreira6 wants to merge 1 commit intomainfrom
marcio/fix-card-min-height
Open

ECHOES-1265 Update sidebar navigation (padding, header, accordion)#657
marciopmoreira6 wants to merge 1 commit intomainfrom
marcio/fix-card-min-height

Conversation

@marciopmoreira6
Copy link
Copy Markdown
Contributor

@marciopmoreira6 marciopmoreira6 commented Mar 23, 2026

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 23, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 99f4529
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/69ce4739f1aedf00085b060a
😎 Deploy Preview https://deploy-preview-657--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update CardStyles.tsx ECHOES-1265 Update CardStyles.tsx Mar 23, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod bot commented Mar 23, 2026

ECHOES-1265

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@marciopmoreira6 marciopmoreira6 marked this pull request as ready for review April 1, 2026 15:13
@marciopmoreira6 marciopmoreira6 changed the title ECHOES-1265 Update CardStyles.tsx ECHOES-1265 Update CardStyles.tsx and changes to the sidebar Apr 1, 2026
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Apr 1, 2026

Summary

This PR updates the sidebar navigation styling and layout with three main changes: (1) removes top padding from the sidebar wrapper and restructures the header with new wrapper components to better manage spacing and responsive behavior; (2) adds a new defaultOpen prop to the accordion item component to allow accordions to open by default; (3) increases the minimum width of the header's main content area and improves flex behavior. The changes are supported by updated tests and expanded Storybook stories demonstrating the new functionality.

What reviewers should know

Start with SidebarNavigationHeader.tsx as it contains the most significant refactoring—new HeaderWrapper and HeaderInnerRow styled components that consolidate spacing logic and add responsive padding adjustments. The key flex change is flex: 1 0 0 on HeaderContainer (previously flex-shrink: 0) which allows the header to fill available space. SidebarNavigationAccordionItem.tsx is straightforward: the new defaultOpen prop simply passes through to useState. Check the test file to see the expected behavior. The Storybook stories were refactored to reduce duplication with shared children components and add new stories to showcase the defaultOpen and responsive docking behavior.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as outdated.

david-cho-lerat-sonarsource

This comment was marked as outdated.

sonar-review-alpha[bot]

This comment was marked as outdated.

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource changed the title ECHOES-1265 Update CardStyles.tsx and changes to the sidebar ECHOES-1265 Update SidebarNavigationHeader Apr 2, 2026
@david-cho-lerat-sonarsource david-cho-lerat-sonarsource changed the title ECHOES-1265 Update SidebarNavigationHeader ECHOES-1265 Update sidebar navigation (padding, header, accordion) Apr 2, 2026
},
};

export const withDisableIconWhenSidebarOpen: Story = {
Copy link
Copy Markdown
Contributor

@david-cho-lerat-sonarsource david-cho-lerat-sonarsource Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we used to have "disableIconWhenSidebarOpen" on the items in this story but that was a no-op as we were not in a sidebar context, now we show that explicitly

@sonarqube-next
Copy link
Copy Markdown

sonarqube-next bot commented Apr 2, 2026

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants