You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the sidebar navigation styling and layout with three main changes: (1) removes top padding from the sidebar wrapper and restructures the header with new wrapper components to better manage spacing and responsive behavior; (2) adds a new defaultOpen prop to the accordion item component to allow accordions to open by default; (3) increases the minimum width of the header's main content area and improves flex behavior. The changes are supported by updated tests and expanded Storybook stories demonstrating the new functionality.
What reviewers should know
Start with SidebarNavigationHeader.tsx as it contains the most significant refactoring—new HeaderWrapper and HeaderInnerRow styled components that consolidate spacing logic and add responsive padding adjustments. The key flex change is flex: 1 0 0 on HeaderContainer (previously flex-shrink: 0) which allows the header to fill available space. SidebarNavigationAccordionItem.tsx is straightforward: the new defaultOpen prop simply passes through to useState. Check the test file to see the expected behavior. The Storybook stories were refactored to reduce duplication with shared children components and add new stories to showcase the defaultOpen and responsive docking behavior.
david-cho-lerat-sonarsource
changed the title
ECHOES-1265 Update CardStyles.tsx and changes to the sidebar
ECHOES-1265 Update SidebarNavigationHeader
Apr 2, 2026
david-cho-lerat-sonarsource
changed the title
ECHOES-1265 Update SidebarNavigationHeader
ECHOES-1265 Update sidebar navigation (padding, header, accordion)
Apr 2, 2026
The reason will be displayed to describe this comment to others. Learn more.
before we used to have "disableIconWhenSidebarOpen" on the items in this story but that was a no-op as we were not in a sidebar context, now we show that explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECHOES-1265