Open
Conversation
it should actually be `/control/lights`, but i guess that changed at some point??? oh well
to prevent us from seeing the rover chassis/antenna post as an obstacle
onkoe
added
tests
we don't use it
now, it drives smoothly without problems :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains fixes and changes made from wheels-on testing in preparation for SAR '26.
Changes
lib/feedback: use wrapping checksum math on Wheelssrc/drive_launcher: tweak Nav2 parameterssrc/navigatornavigator_node: use new lights service path (/lights_service... idk why it changed but oh well)navigator_node: openasynciotask before running navigator (not sure if we need this on other Python nodes, but they all seem to work fine in comparison???)utm_conversion_node: use working QoS settings forodomandgpssrc/soro_lidar: set a minimum range on the LiDAR detection. otherwise, we detect our chassis/GPS antenna as an object to avoid