Basic handling of relative type-paths to procs#266
Basic handling of relative type-paths to procs#266Leshana wants to merge 1 commit intoSpaceManiac:masterfrom
Conversation
|
I don't consider being bug-compatible with DM a goal of SpacemanDMM. I consider /atom/proc/callee()
/atom/proc/caller()
/atom/movable/caller()
world << .callee/atom/proc/callee()
/atom/movable/proc/caller()
world << .callee/atom/movable/proc/callee()
/atom/proc/caller()
/atom/movable/caller()
world << .calleeIf you're putting in the work to make SpacemanDMM a little closer to DM without compromising the structure of SpacemanDMM that's fine, but I'd rather get on the mark than overcorrect in the other direction (accepting code which DM rejects). Also, is it worth encouraging (allowing?) coders to use |
|
Hmm, actually those are not correctly found as errors. In fact, it looks like detecting those would be quite difficult in the current SpacemanDMM architecture, as resolution depends on whether or not the lexically enclosing proc is a "proc" proc vs. an overridden proc. |
|
Sounds like that's probably not worth the complexity. The question then is whether to err on the side of generous or strict. My first instinct is to go for strict - not accepting |
Fixes false errors arising from relative paths to procs such as: error: failed to resolve path .HasProximity even when HasProximity is defined on the current type.
Details:
Example failure case: