Skip to content

Remove healing combat intterupt and add EF to walk over monster#1486

Open
mtwango wants to merge 4 commits intoSphereserver:devfrom
mtwango:features
Open

Remove healing combat intterupt and add EF to walk over monster#1486
mtwango wants to merge 4 commits intoSphereserver:devfrom
mtwango:features

Conversation

@mtwango
Copy link
Member

@mtwango mtwango commented Oct 1, 2025

optional OF_DontInterruptHealOnHit to skip interrupt on getting hit, so scripters can implement their interrupt in hit / gethit triggers
experimental EF_WalkBypassMonsters to leverage personalspace trigger on NPC without full stamina. Experimental, because this is resource intensive (lots of packets) when denied by trigger.

@mtwango
Copy link
Member Author

mtwango commented Oct 6, 2025

Note: healing doesnt get interrupted by hit, but still fails on skill abort. Might be related to #1442

@mtwango mtwango marked this pull request as draft January 31, 2026 15:50
@mtwango
Copy link
Member Author

mtwango commented Jan 31, 2026

Need to fix the branch, since I merged some stuff here on our shard by accident.

@mtwango mtwango marked this pull request as ready for review February 9, 2026 16:01
@mtwango
Copy link
Member Author

mtwango commented Feb 11, 2026

The healing OF is for discussion.

Maybe it should not be as a OF, but removed by default. It doesn't take into account veterinary (in core) and seems like an agressive way to stop action, since scripters can make an easy replacement in scripts, ie in character events:

on=@getHit
  if (<action> == Healing)
    sysmessage <defmsg.healing_interrupt>
    action = -1
  endif

This reverts commit fc94729.

Removed heal interrupt completely with info, how to add it to scripts
@mtwango
Copy link
Member Author

mtwango commented Mar 4, 2026

Great discussion :D

I've updated the PR to remove healing interrupt and how to add it to script pack.

@mtwango mtwango changed the title Feature Flags Remove healing combat intterupt and add EF to walk over monster Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant