Add load_templates_clusters parameter (kilosort/phy output)#4376
Open
pas-calc wants to merge 2 commits intoSpikeInterface:mainfrom
Open
Add load_templates_clusters parameter (kilosort/phy output)#4376pas-calc wants to merge 2 commits intoSpikeInterface:mainfrom
pas-calc wants to merge 2 commits intoSpikeInterface:mainfrom
Conversation
…refinement) Added a new parameter 'load_templates_clusters' to control loading of templates or clusters from Kilosort output. Updated logic to handle loading based on the parameter value.
for more information, see https://pre-commit.ci
Member
|
Hi @pas-calc, thanks for this! It sounds like it's correct for the default to be "templates" since this always represents the "raw" outputs. This function is very new and hasn't been in a release version yet, so we don't need to be so careful about backward compatibility. Hence I would vote to make "templates" the default and remove the "auto" option. What do you think? Maybe we should also make it clear in the docstring that this function is only tested for data that has not been modified by Phy. EDIT: also, do you know if kilosort 2.5 also outputs both of these files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new parameter 'load_templates_clusters' to control loading of templates or clusters from Kilosort output. Updated logic to handle loading based on the parameter value.
Have "auto" as default to ensure backward compatibility, as this was the previous implementation.
related:
#4373
We could also store a kwarg dict / attribute so that we later know from where we got the clusters, especially if "auto" was chosen.