1 feature adapt arms for using with 26 wheels#1
Open
momu wants to merge 2 commits intoSpokeSpice:mainfrom
Open
1 feature adapt arms for using with 26 wheels#1momu wants to merge 2 commits intoSpokeSpice:mainfrom
momu wants to merge 2 commits intoSpokeSpice:mainfrom
Conversation
adapt length to fit 26" wheels
zonque
reviewed
Jun 23, 2024
Member
There was a problem hiding this comment.
Had a quick look and the design looks good to me.
One thing I spotted is the difference in the inter-LED connects, you should either use the rounded style or the one with 45° angles. I personally prefer the latter, but it should at least be unified:
Also, I would like to have both version next to each other, so could you move the existing layout to an "28-inch" folder and add your in one named "26-inch"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zonque Would be nice if you can have a short look if the adapted arm looks okayish