Catch exception objects by const reference#161
Merged
zauguin merged 1 commit intoSqliteModernCpp:devfrom May 20, 2018
Merged
Conversation
A version of SqliteModernCpp#160 on the `dev` branch.
Collaborator
Author
|
@Peter-Levine Please review this one. It should fix all the problematic |
|
@zauguin The dev branch never caused failure on my end since the exceptions are caught by reference, but it's a good idea to catch by const reference. I can confirm there is no build failure with the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A version of #160 on the
devbranch.