Store error message also for basic return codes.#232
Open
WKarel wants to merge 5 commits intoSqliteModernCpp:devfrom
Open
Store error message also for basic return codes.#232WKarel wants to merge 5 commits intoSqliteModernCpp:devfrom
WKarel wants to merge 5 commits intoSqliteModernCpp:devfrom
Conversation
While `throw_sqlite_error` is called with the return value of `sqlite3_errmsg` everywhere, `throw_sqlite_error` uses this argument only for extended result codes, and discards it for basic ones. ced361f must have left that out by accident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
throw_sqlite_erroris called with the return value ofsqlite3_errmsgeverywhere,throw_sqlite_erroruses this argument only for extended result codes, and discards it for basic ones. ced361f must have left that out by accident.