fix: add missing n_frames attribute in StandardDiffusionLoss#471
Open
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Open
fix: add missing n_frames attribute in StandardDiffusionLoss#471Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardDiffusionLoss._forward()referencesself.n_framesto determine the offset noise shape, but this attribute is never initialized in__init__(), causing anAttributeErrorwhenoffset_noise_level > 0.0.n_framesas an optional parameter to__init__()(defaulting toNone) and assigned it toself.n_frames, preserving the existing behavior whereNoneselects the 2D (image) offset noise shape.Details
In
sgm/modules/diffusionmodules/loss.py, the_forwardmethod contains:self.n_framesis checked but never defined anywhere in the class, so any use ofoffset_noise_level > 0.0raises:This fix adds
n_frames: Optional[int] = Noneto the constructor and stores it asself.n_frames. The default ofNonemeans existing configs and image-based training are unaffected, while video-based training can passn_framesto get the correct 3D offset noise shape.Test plan
n_frames) continue to work unchanged since the default isNoneAttributeError