fix: pass all arguments through gradient checkpoint in BasicTransformerBlock#474
Open
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Open
fix: pass all arguments through gradient checkpoint in BasicTransformerBlock#474Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Mr-Neutr0n wants to merge 1 commit intoStability-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasicTransformerBlock.forward()silently dropsadditional_tokensandn_times_crossframe_attn_in_selfwhen gradient checkpointing is enabled. Thecheckpoint()call only forwardsxandcontext, causing the other two arguments to revert to their defaults (Noneand0):This means that during training with checkpointing enabled:
additional_tokensis silently ignored (defaults toNone), so any extra conditioning tokens passed to self-attention and cross-attention are lost.n_times_crossframe_attn_in_selfis silently ignored (defaults to0), so cross-frame attention repeat behavior in self-attention is disabled.The non-checkpointed path (
self._forward(**kwargs)) correctly passes all arguments, so this bug only manifests whencheckpoint=True— the default setting — making it easy to miss.Fix
Pass all four arguments through
checkpoint():This ensures
_forwardreceives the same arguments regardless of whether gradient checkpointing is enabled.