Web3Auth bug fix#47
Open
Ian-Bright wants to merge 5 commits intofeat/v0.3from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #46
This branch aims to fix a bug where on some occasions signing in with Web3Auth will not trigger the modal to pop up. In some occasions this appears to be due to bad initialization.
There is a bug that occurs however when attempting to disconnect and sign in again. It is not easily reproducible but can be reproduced with the following steps:
The modal will not open afterwards. Opened an issue on the Web3Auth github addressing this but more now just added a window.reload() when we log out as a hacky fix