update dotastats to v1.2.1#140
Open
BambooFury wants to merge 6 commits intoSteamClientHomebrew:mainfrom
Open
Conversation
Member
|
Are static images necessary? Could they just be put on a CDN and fetched over the internet? Your plugin is about 2 MB which is alot compared to others. The servers we host Millennium on aren't cheap unfortunately. |
Contributor
Author
|
Thank you for the suggestion! I'll switch to loading rank icons from a CDN instead of bundling them locally. This will also fix the steamloopback initialization issue we have when navigating quickly between Steam sections. Will update the PR soon. |
Contributor
Author
|
Done! Switched to jsDelivr CDN, plugin is now ~9.6 KB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.