Update: decky-download-all to v1.1.0

[bentemple]

Update decky-download-all to v1.1.0

Fixes download-all not working on SteamOS 3.8+ due to the new format associated with controlling downloads on remote machines

Fixes bentemple/decky-download-all#1

Task Checklist

Developer

• I am the original author or an authorized maintainer of this plugin.
• I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.
• Generative AI was NOT used to write a majority of the code I am submitting.
  -- I did use claude to help make these changes, I'm not a web-dev by trade, so it helps me bridge that gap (Java, C++, C, Kotlin, Python are my main native languages), but I have reviewed, and modified all of the code that was changed. See below comment on this. These are crafted commits, that I made. Not AI slop, but I don't really know the intention behind this check-box, but I do want to disclose the use.

Plugin

• I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
• I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

• No: I am using a custom backend other than Python.
• No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
• No: I am using a custom binary that has all of it's dependencies statically linked.

Community

• I have tested and left feedback on two other pull requests for new or updating plugins.
• I have commented links to my testing report in this PR.

Testing

• Tested by a third party on SteamOS Stable or Beta update channel.

[github-actions]

Issues Found

No issues with your PR description were found.

Next Steps

1. If we found any issues above, please edit your pull request description to resolve them and leave a comment saying you've done so.
2. For the quickest review, please see the Community section of the pull request template for how you can help other developers.
3. Once your description is correct, a maintainer will review your pull request as soon as possible.

Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️

[bentemple]

Be me:
Release your first decky plugin
Test it, use it, enjoy it.
New SteamOS beta releases a week later.
Plugin breaks because they change the download data format that hasn't changed for a long time
😞

The changes are slightly more than they would have to be, but I left the logging (from web->python so I can just debug with ssh) in because felt nice to keep that for anyone using it -- in-case they would want logs for some reason. Also makes debugging future issues a lot easier.

[bentemple]

Also, re generative AI:
This is a new check-box and I don't really know what the majority means, but I want to call-out that there's nuance here

If majority means I initially started with claude to make this change, initially, then yes.

If majority means I just let claude do whatever it wanted and then didn't review, edit, and test the code, and redirect claude when it decided to make a shitty change, then no, I didn't. I have gone through the changes, verified them, understood them and edited them as-needed

This isn't an AI slop PR. I think one of the worst things AI does is make too many changes at once. I added, and then left in the logging stuff as kind of a completeness thing because it felt like something I would want as an end-user. (i.e. as a user, I would kind of expect the logging of a plugin to include the actions it takes, but I could make this PR super lean by not including all of main, but instead just the change required to fix 3.8+) And then it will make debugging future issues easier, but if that code being included causes any hesitation, I'm happy to split it out and trim this down to exactly the change required to fix 3.8+

[bentemple]

Also, re the submitting plugins:

 "AI", LLMs and so on

No. We do not accept any plugin that uses any LLM based code as these models do not comply with the GPL license (of which we are one of many many users) and thus cannot in good conscience accept plugins which have scraped or actively scrape the work of human beings without proper credit, permission and or compensation. This will not be a debate. Any LLM focused plugins will be rejected outright and there will be no appeals.

When I first read this, I had understood this to mean any plugin that uses AI (leveraging AI, in other words), but re-reading in conjunction with this new check-box added (between my initial plugin and this update) I'm not so sure, that's the case. and it is in-fact a commitment that no plugin can use generative AI to help build it.

I certainly don't disagree with the sentiment here. generative AI is definitely and 100% a direct result of GPL code, and therefore all AI should be GPL, imo, including anything written by AI.

Anyway, I like my plugin. I think it's simple, focused, and solves an annoying problem. But if it needs to just be for me, then so be it. I don't want to break any community rules here, just trying to make useful shit for myself, and then because I love OSS taking the time to craft it to a quality bar that I think is high enough to share with others as well.

[EMERALD0874]

Our main concerns are making sure all code is secure, tested, and properly licensed (given you cannot license AI-generated code unless under certain circumstances per US copyright law). Since this is a fairly small change, I don't think this is an issue.

[EMERALD0874]

LGTM for testing

[bentemple]

Our main concerns are making sure all code is secure, tested, and properly licensed (given you cannot license AI-generated code unless under certain circumstances per US copyright law). Since this is a fairly small change, I don't think this is an issue.

Got it. Appreciate the reply. Yeah by the logic presented here IMO, the only ethical application of an llm IS in producing public GPL code. Which this is of course under the GPL license. Thank you for the response. I definitely did not slop this out and one of the best defenses against AI slop, IMO, is atomic commits which require splitting and carefully reviewing every line changed. Which I did here (as I will always do when leveraging an LLM)

I really like how Jellyfin has clearly defined their AI policy. Would love to see some better clarity around the policy here.

Sorry, for the slight freak-out. was just my 2AM brain going: did I completely mis-read this policy etc...

[mdeguzis]

No major issues seen in code submission. Auto builds (https://github.com/bentemple/decky-download-all/actions) look clean.

[mdeguzis]

Your LICENSE is incorrect. Please see the license of the plugin template repo and replace "Hypothetical Plugin Developer".