-
Notifications
You must be signed in to change notification settings - Fork 14
Support trusting Aspire-mapped ASP.NET Core dev certs (SBA as JVM app) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
28fae7f
bump to Spring Boot 3.5.10, update READMEs, add AGENTS.md
TimHess e4493ac
Support trusting Aspire dev certs
TimHess 5ce7172
Apply suggestions from code review (#53)
TimHess 58d5ae6
Address PR review feedback
TimHess 01cfbdf
update default docker org
TimHess eff495c
limit ssl-related changes to SBA
TimHess 8c58e1c
apply patches with "git apply" instead of "patch"
TimHess 88b49e7
pr feedback
TimHess 2956bc1
enable class data sharing for non-native images (.5 second faster sta…
TimHess 8c9534c
BP_JVM_CDS_ENABLED => BP_JVM_AOTCACHE_ENABLED
TimHess 9821cd2
Build on PR to any branch, but with more restictive path filter
TimHess 5be24ba
switch from native to aot
TimHess e962116
use java 25
TimHess 44fb9d3
Use default .gitattributes, except for .patch files
bart-vmware b050e7c
reapply rules from .gitignore
bart-vmware c4744be
update jdk listed in readme
TimHess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| *.jar binary | ||
| * text eol=lf | ||
| # Patches are applied on files extracted from a downloaded zip file. All these files use LF line endings. | ||
| *.patch text eol=lf | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Agent Instructions and Reminders | ||
|
|
||
| This file contains important reminders and guidelines for AI agents working on this codebase. | ||
|
|
||
| ## Build Script | ||
|
|
||
| ### Avoid `-DisableCache` Flag | ||
|
|
||
| **Do NOT use `-DisableCache`** when running `build.ps1` from agentic contexts. The `start.spring.io` service may block or rate-limit automated traffic, causing connection failures. | ||
|
|
||
| Instead, to get a fresh build: | ||
|
|
||
| 1. Delete the expanded project folder (e.g., `workspace/springbootadmin/`) | ||
| 2. Run `.\build.ps1 <image-name>` without the flag | ||
|
|
||
| ### Testing Changes | ||
|
|
||
| Before submitting patch changes: | ||
|
|
||
| 1. Run a dry-run of each patch: `git apply --check <patch-file>` | ||
| 2. If dry-run succeeds, run the full build and verify Java compilation | ||
| 3. Test the resulting Docker image with a real client app | ||
|
|
||
| ## Patch Files | ||
|
|
||
| The build script uses `git apply --unidiff-zero --recount --ignore-whitespace` to apply patches, which is more forgiving than the traditional `patch` command. | ||
|
|
||
| ### Patch Format Rules | ||
|
|
||
| 1. **Hunk headers should be accurate**: The format is `@@ -old_start,old_count +new_start,new_count @@` | ||
| - `old_count` is the number of lines in the hunk from the old file (context lines plus lines with `-` prefix) | ||
| - `new_count` is the number of lines in the hunk in the new file (context lines plus lines with `+` prefix) | ||
| - For new file patches (`--- /dev/null`), `old_count` is 0 and `new_count` is the total number of lines in the new-file hunk | ||
| - Note: `--recount` will automatically correct line counts, but keeping them accurate is still good practice | ||
| 2. **Trailing newlines are required**: Patch files must end with a newline character. | ||
| 3. **Preserve exact whitespace**: Context lines must match the target file exactly, including trailing spaces and tabs. The `--ignore-whitespace` flag provides some tolerance but exact matches are preferred. | ||
| 4. **New file patches**: Use `/dev/null` as the old file: | ||
|
|
||
| ```diff | ||
| --- /dev/null | ||
| +++ ./path/to/NewFile.java 2026-01-27 00:00:00.000000000 +0000 | ||
| @@ -0,0 +1,N @@ | ||
| +line 1 | ||
| +line 2 | ||
| ... | ||
| ``` | ||
|
|
||
| ### Example | ||
|
|
||
| If a patch adds 1 line, the hunk header should reflect this: | ||
|
|
||
| ```diff | ||
| -@@ -37,3 +37,10 @@ | ||
| +@@ -37,3 +37,11 @@ | ||
| ``` | ||
|
|
||
| ### Why This Matters | ||
|
|
||
| While `git apply --recount` can fix minor line count issues, keeping patches accurate ensures reliable application and easier debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 4.3.0 | ||
| 4.3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.5.6 | ||
| 3.5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| --- ./build.gradle 2025-09-30 14:48:20.000000000 -0500 | ||
| +++ ./build.gradle 2025-09-30 14:49:16.584226000 -0500 | ||
| @@ -41,3 +41,10 @@ | ||
| @@ -41,3 +41,11 @@ | ||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| } | ||
| + | ||
| +bootBuildImage { | ||
| + createdDate = "now" | ||
| + environment = [ | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true" | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true", | ||
| + "BP_JVM_AOTCACHE_ENABLED": "true" | ||
| + ] | ||
| +} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 4.3.0 | ||
| 4.3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.5.6 | ||
| 3.5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| --- ./build.gradle 2025-09-30 14:48:20.000000000 -0500 | ||
| +++ ./build.gradle 2025-09-30 14:49:16.584226000 -0500 | ||
| @@ -41,3 +41,10 @@ | ||
| @@ -41,3 +41,11 @@ | ||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| } | ||
| + | ||
| +bootBuildImage { | ||
| + createdDate = "now" | ||
| + environment = [ | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true" | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true", | ||
| + "BP_JVM_AOTCACHE_ENABLED": "true" | ||
| + ] | ||
| +} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.5.5 | ||
| 3.5.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.5.6 | ||
| 3.5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| --- ./build.gradle 2025-09-22 14:48:20.000000000 -0500 | ||
| +++ ./build.gradle 2026-01-27 00:00:00.000000000 -0500 | ||
| @@ -38,3 +38,10 @@ | ||
| @@ -38,3 +38,11 @@ | ||
| tasks.named('test') { | ||
| useJUnitPlatform() | ||
| } | ||
| + | ||
| +bootBuildImage { | ||
| + createdDate = "now" | ||
| + environment = [ | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true" | ||
| + "BP_SPRING_CLOUD_BINDINGS_DISABLED": "true", | ||
| + "BP_JVM_AOTCACHE_ENABLED": "true" | ||
| + ] | ||
| +} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.