feat: Focus mode reminder when recording without DND#112
feat: Focus mode reminder when recording without DND#112StevenLi-phoenix wants to merge 1 commit intomainfrom
Conversation
Add FocusModeService to check macOS Focus/DND status via INFocusStatusCenter, FocusReminderBanner overlay in ContentView, and a toggle in Recording settings. When recording starts without Focus mode active, a dismissable banner suggests enabling DND to avoid notification sounds in the recording. Closes #103
❌ Claude Code Review: REJECT
|
|
|
Notes — Focus Mode Reminder (#103)232 行、6 文件——轻量但高价值。 1. INFocusStatusCenter
2. Banner 设计"Open Settings" + dismiss + "Don't show again"三个操作覆盖了所有用户意图。 建议补充第四个选项:"Auto-enable DND"——直接为用户开启 Focus 模式(通过 3. 与 Meeting Templates 集成PR #101 的模板可以指定"此模板总是启用 Focus"——面试模板、保密会议模板等。 4. 通知声录入问题Focus mode 的核心价值:录音过程中通知声会被 ASR 捕获,影响转录质量。这一点建议在 banner 文案中明确告知用户——"通知声可能被录入音频"比"建议开启勿扰"更有说服力。 5. 持久化"Don't show again" 用 |
Focus Mode 集成路径macOS 的 Focus 状态检测有权限限制。最低成本的实现:
|
Summary
FocusModeService(nonisolated enum) that checks macOS Focus/DND status viaINFocusStatusCenterFocusReminderBanneroverlay inContentViewshown when recording starts without Focus mode active — includes "Open Settings" (opens Focus system preferences), dismiss, and "don't remind again" buttonsfocusReminderEnabledtoggle in Recording settings tabTest plan
CODE_SIGNING_ALLOWED=NO)FocusModeServiceTests— 6/6 passCloses #103