feat: @Generable structured summary output (#44)#59
Open
StevenLi-phoenix wants to merge 1 commit intomainfrom
Open
feat: @Generable structured summary output (#44)#59StevenLi-phoenix wants to merge 1 commit intomainfrom
StevenLi-phoenix wants to merge 1 commit intomainfrom
Conversation
…#44) - Add StructuredSummary (@generable + Codable) with summary, keyPoints, actionItems, sentiment - FoundationModelsEngine uses @generable for on-device structured generation - Other engines (OpenAI/Anthropic/Ollama) use SummarySchemaProvider JSON Schema - SummarizerService.summarizeWithFallback() tries structured first, falls back to plain text - SummaryCardView renders sectioned display (key points, action items, sentiment badge) - SchemaV7 adds structuredContent to SummaryBlock (lightweight migration) - 19 new tests across 2 test suites Closes #44
✅ Claude Code Review: APPROVE
|
Contributor
|
⏸️ Auto-merge paused: 3 unchecked checkbox(es) in PR body. Merge will proceed automatically once all tasks are checked and a new push triggers the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StructuredSummarymodel with@Generable+Codablefor structured summary output (summary, key points, action items, sentiment)FoundationModelsEngineuses Apple's@Generablemacro for on-device structured generation; other engines useSummarySchemaProviderJSON Schema via existinggenerateStructured()protocolSummarizerService.summarizeWithFallback()tries structured output first, gracefully falls back to plain textSummaryCardViewrenders sectioned display with key points, action items, and sentiment badge when structured data is availablestructuredContent: String?toSummaryBlockFiles Changed
StructuredSummary.swift,SchemaV7.swift,StructuredSummaryTests.swift,SummarizerStructuredTests.swiftSummaryBlock.swift,NotetakerMigrationPlan.swiftFoundationModelsEngine.swiftSummarizerService.swift,PromptBuilder.swift,BackgroundSummaryService.swift,SummaryMarkdownFormatter.swiftSummaryCardView.swift,SessionDetailView.swiftRecordingViewModel.swiftUnitTests.xctestplan,CLAUDE.mdTest plan
Closes #44
🤖 Generated with Claude Code