feat: karaoke-style transcript sync during playback#63
Open
StevenLi-phoenix wants to merge 1 commit intomainfrom
Open
feat: karaoke-style transcript sync during playback#63StevenLi-phoenix wants to merge 1 commit intomainfrom
StevenLi-phoenix wants to merge 1 commit intomainfrom
Conversation
- Add KaraokeSync.findActiveIndex(at:in:) binary search for active segment - Add isActive highlight and tappable timestamp to TranscriptSegmentRow - Pass activeSegmentID + onTimestampTap through TranscriptView - Track playback time in SessionDetailView, auto-scroll to active segment - Pause auto-scroll for 3s on user scroll (onScrollPhaseChange) - Reset karaoke state on session change and view disappear - Add 8 unit tests for KaraokeSync binary search - Update UnitTests.xctestplan and CLAUDE.md
❌ Claude Code Review: REJECT
|
Contributor
|
|
Owner
Author
修复建议 — Karaoke Sync (REJECTED)Review 指出 修复方案
建议方案 B 最安全——karaoke sync 的核心功能是播放时高亮,导出可以在 #61 合并后再集成。 |
This was referenced Mar 28, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #18
🤖 Generated with Claude Code