Skip to content

Update ffmpeg to 8.1 from 8.0.1 #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rob93c wants to merge 4 commits into from
Closed

Update ffmpeg to 8.1 from 8.0.1 #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbdda30
Add write permissions for contents in bump workflow
rob93c Mar 19, 2026
06d1be8
Configure BUMP_TOKEN in bump.yaml
rob93c Mar 19, 2026
7860bad
Update ffmpeg to 8.1 from 8.0.1
Mar 19, 2026
b794708
Improve bump configuration to update all FFmpeg dependencies at once
rob93c Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/bump.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,18 @@ on:
schedule:
- cron: '0 8 * * *'

permissions:
contents: write

jobs:
bump:
name: Search for dependency updates
runs-on: ubuntu-latest
steps:
- name: Checkout code changes
uses: actions/checkout@v6
with:
token: ${{ secrets.BUMP_TOKEN }}

- name: Update dependencies
uses: wader/bump/action@master
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup FFmpeg and FFprobe
uses: ./.github/actions/setup-ffmpeg
with:
# bump: ffmpeg-ci /ffmpeg-version: ([\d.]+)/ docker:mwader/static-ffmpeg|/\d+\./|*
# bump: ffmpeg /ffmpeg-version: ([\d.]+)/ docker:mwader/static-ffmpeg|/\d+\./|*
ffmpeg-version: 8.0.1
Comment on lines +29 to 30
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify FFmpeg version references in Dockerfile and workflows
set -euo pipefail
rg -n --type=yaml --type=dockerfile 'ffmpeg-version|mwader/static-ffmpeg'

Repository: Stickerifier/Stickerify

Length of output: 101

🏁 Script executed:

#!/bin/bash
# Verify FFmpeg version references across configuration files
set -euo pipefail

echo "=== Searching for ffmpeg-version in YAML files ==="
rg -n 'ffmpeg-version' --type yaml

echo ""
echo "=== Searching for mwader/static-ffmpeg in all files ==="
rg -n 'mwader/static-ffmpeg'

echo ""
echo "=== Checking Dockerfile for FFmpeg references ==="
fd -e Dockerfile -e dockerfile | head -5

Repository: Stickerifier/Stickerify

Length of output: 117

🏁 Script executed:

#!/bin/bash
# Check if the workflow file exists and read it
echo "=== Checking .github/workflows/unit-test.yml ==="
if [ -f ".github/workflows/unit-test.yml" ]; then
  wc -l ".github/workflows/unit-test.yml"
  echo ""
  sed -n '25,35p' ".github/workflows/unit-test.yml"
else
  echo "File not found"
fi

echo ""
echo "=== Find all YAML files in .github/workflows ==="
find .github/workflows -name "*.yml" -o -name "*.yaml" 2>/dev/null | head -10

Repository: Stickerifier/Stickerify

Length of output: 625

🏁 Script executed:

#!/bin/bash
# Check setup-ffmpeg action and Dockerfile
echo "=== Checking .github/actions/setup-ffmpeg/action.yml ==="
if [ -f ".github/actions/setup-ffmpeg/action.yml" ]; then
  cat -n ".github/actions/setup-ffmpeg/action.yml"
else
  echo "File not found"
fi

echo ""
echo "=== Find Dockerfile ==="
find . -name "Dockerfile" -type f

echo ""
echo "=== Check for any Docker image references ==="
rg 'mwader/static-ffmpeg' -n --no-heading

Repository: Stickerifier/Stickerify

Length of output: 2654

Align CI FFmpeg version with runtime (8.1).

Unit tests install ffmpeg-version: 8.0.1, while the Dockerfile deploys mwader/static-ffmpeg:8.1. This mismatch can allow regressions specific to 8.1 to slip through CI.

Proposed change 
-          ffmpeg-version: 8.0.1
+          ffmpeg-version: 8.1
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# bump: ffmpeg /ffmpeg-version: ([\d.]+)/ docker:mwader/static-ffmpeg|/\d+\./|*
ffmpeg-version: 8.0.1
# bump: ffmpeg /ffmpeg-version: ([\d.]+)/ docker:mwader/static-ffmpeg|/\d+\./|*
ffmpeg-version: 8.1
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/unit-test.yml around lines 29 - 30, CI is installing
ffmpeg-version: 8.0.1 which mismatches the runtime Docker image
mwader/static-ffmpeg:8.1; update the ffmpeg-version entry in
.github/workflows/unit-test.yml from 8.0.1 to 8.1 so the unit-test workflow uses
the same FFmpeg release as the Dockerfile (confirm by locating the
mwader/static-ffmpeg:8.1 reference in the Dockerfile and keeping both versions
in sync).


- name: Setup Java
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM eclipse-temurin:25-alpine AS builder
WORKDIR /app

# bump: ffmpeg /static-ffmpeg:([\d.]+)/ docker:mwader/static-ffmpeg|/\d+\./|*
COPY --from=mwader/static-ffmpeg:8.0.1 /ff* /usr/bin/
COPY --from=mwader/static-ffmpeg:8.1 /ff* /usr/bin/

COPY . .
RUN --mount=type=cache,target=/root/.gradle ./gradlew check installDist --no-daemon
Expand Down
Loading