Bug: Redirect happens even when fetch fails in paymentSummary.js#163
Open
SmartSankarCode wants to merge 1 commit intoSuperSimpleDev:mainfrom
Open
Bug: Redirect happens even when fetch fails in paymentSummary.js#163SmartSankarCode wants to merge 1 commit intoSuperSimpleDev:mainfrom
SmartSankarCode wants to merge 1 commit intoSuperSimpleDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! @SuperSimpleDev
I noticed that the app redirects to orders.html even if the fetch request fails.
This happens because window.location.href = 'orders.html'; is outside the try...catch, so it runs no matter what.
Maybe you could move the redirect inside the try block, so it only happens if the fetch is successful?
Example:
try {
const response = await fetch(...);
const order = await response.json();
addOrder(order);
window.location.href = 'orders.html'; // redirect after success
} catch (error) {
console.log('Unexpected error. Try again later.');
}
Just a small thing I noticed. Thanks for the cool project! @SuperSimpleDev