Do not swallow error when importing plugins#1705
Merged
mnaberez merged 1 commit intoSupervisor:mainfrom Dec 21, 2025
Merged
Conversation
SuperSandro2000
commented
Dec 7, 2025
| 'thisishopefullynotanimportablepackage:nonexistent cannot be ' | ||
| 'resolved within [eventlistener:cat]') | ||
| 'resolved within [eventlistener:cat]: No module named ' | ||
| '\'thisishopefullynotanimportablepackage\'') |
Contributor
Author
There was a problem hiding this comment.
I am not sure how to handle the quoting issues here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an error in knot-resolver v6 when importing its plugin which before looked like:
which was not very actionable or clear for me.
Now the error is: