Open
Conversation
- Replace invalid instruction marker '!!!' with the invalid opcode - Exit with a cancellation message instead of unwinding stack on SIGINT
- `jnc` = `jlo` - `jnz` = `jne` - `jc` = `jhs` - `jz` = `jeq`
- Remove comments from lines before processing - Remove comment-stripping logic from each function - Skip empty/comment-only lines - Use regex to identify relative jump offset number - This fixes a bug where jump offset always needed + or - - Use regex to split opcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes:
msprobe.py:-mcpassedassemble.py:assembleOneOpInstructionslice index produced incorrect machine codeassembleRegisterIndirect Source mode produced invalid register name+or-would always be treated as labels since[0-9]is alphanumericAssembleRegister(object is string, not int)Formatting improvement: