Conversation
For some reason that fixes the request to the openid discovery endpoint.
Instead of just the message, propagate the complete error structure
Panaetius
reviewed
Mar 11, 2026
| cmd.args(["--renku-url", "https://ci-renku-3668.dev.renku.ch"]); //use mock url? | ||
| let prg = cargo::cargo_bin!("rnk"); | ||
| let mut cmd = Command::new(prg); | ||
| cmd.args(["--renku-url", "https://dev.renku.ch"]); //use mock url? |
Member
There was a problem hiding this comment.
Suggestion: I've had good results using https://github.com/microsoft/injectorppforrust to just mock api requests so my tests don't depend on an external API being up, maybe that could be useful in the renku cli as well?
Member
Author
There was a problem hiding this comment.
Thanks, yes maybe that is convenient. Could be looked into in a later PR.
Panaetius
approved these changes
Mar 11, 2026
Member
Panaetius
left a comment
Panaetius
left a comment
There was a problem hiding this comment.
looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login command was failing due to a failed request to fetch the openid-configuration. The error message was
The error message is not very clear (it is an http/https url). Adding the
oauth2as an explicit dependency fixes this issue. This dependency was already defined transitively by the openidconnect crate.Additionally, a small refactoring to not only pass the error message but the complete source error into the snafu wrapper structure.
supersedes #49