Conversation
Just want to see what happens. If the performance sucks, I'll try it with 5 or 6 bits. If the difference is negligible, I'll remove it properly.
|
Definitely seeing some improvements by switching away from the green channel rods n' cones biasing thing. When I completely turn off the color caching and run this test script, there is a noticeable performance hit when turboing. I'd say it goes from 25x to 10x speed. As such, I changed the color cache to 5 bits per channel and it seems fine... But I'm still a bit leery, so I might make a Lua API that can turn this on and off just in case 5 bits still makes things weird. Here are some comparison results. Hopefully it's not too hard to see. With the green bias, the ghosts get kind of yellowy when they stack up. 3-bit green bias (the ways things are in master) 3bit-green_bias.mp4no cache euclid (best results, noticeable performance dip when turboing) no_cache-euclid.mp45-bit Euclid 5bit-euclid.mp43 bit euclid 3bit-euclid.mp4no cache green bias no_cache-green_bias.mp4 |
Don't mind me, just using your appveyor to avoid setting up Visual Studio on my new PC :)