fix(security): replace shell=True with shlex.split() to prevent shell injection#2113
Open
Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Open
fix(security): replace shell=True with shlex.split() to prevent shell injection#2113Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Jah-yee wants to merge 1 commit intoTEN-framework:mainfrom
Conversation
… injection Fixes TEN-framework#2107 and TEN-framework#2106 This change addresses security vulnerabilities where subprocess.run() was called with shell=True, which allows shell injection attacks. Replaced with shlex.split() to properly parse commands without invoking a shell interpreter.
Jah-yee
pushed a commit
to Jah-yee/ten-framework
that referenced
this pull request
Mar 18, 2026
…njection Replaces dangerous shell=True in subprocess.run with shell=False + shlex.split() to prevent shell injection vulnerabilities in 5 files: - ai_agents/agents/examples/voice-assistant-nodejs/.../run_script.py - packages/core_apps/default_app_cpp/tools/run_script.py - packages/core_extensions/default_extension_cpp/tools/run_script.py - packages/core_extensions/default_extension_nodejs/tools/run_script.py - packages/example_apps/transcriber_demo/.../run_script.py Fixes issues TEN-framework#2107, TEN-framework#2106, TEN-framework#2111, TEN-framework#2113, TEN-framework#2114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2107 and #2106
This change addresses security vulnerabilities where subprocess.run() was called with shell=True, which allows shell injection attacks.
Replaced with shlex.split() to properly parse commands without invoking a shell interpreter.
Files modified: