Fix reference pressure in geo_strf_dyn_height#87
Merged
efiring merged 1 commit intoTEOS-10:mainfrom Feb 24, 2026
Merged
Conversation
With specific combinations of inputs, the generation of an interpolated grid for the geostrophic streamfunction calculation would fail to find the correct index of the reference pressure entry in the new grid. Then the dynamic height integration would be correct, but it would not be referenced to the specified reference pressure.
ocefpaf
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With specific combinations of inputs, the
generation of an interpolated grid for the
geostrophic streamfunction calculation would fail
to find the correct index of the reference
pressure entry in the new grid. Then the dynamic
height integration would be correct, but it would
not be referenced to the specified reference
pressure.
See TEOS-10/GSW-Python#225 for additional information and tests. The current PR addresses the original problem identified in TEOS-10/GSW-Python#224, which is in the routine that generates the interpolation grid; it could occur with any of the 3 interpolation options.