Open
Conversation
Contributor
|
This is great but once we excluded the tests, the coverage falls below our threshold. Mainly because CLI code is not tested anymore since we need to re-implement it. Can you remove all the CLI code and CLI documentation for now. Then coverage should be fine. We can always get it back from the old tags if needed. |
f40e60f to
1ecec6d
Compare
a5c476f to
5070c47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #574
Remove the tests source code (tests/) from the codebase used for the mdio-python package code coverage calculations.
Notes:
This PR:
pytest-covto the dev dependency-groups in order to allow measuring code coverage with VS Codetests/from the code coverage. (NOTE: settingsource = ["src/mdio"]is not enough andomitneeds to be used)Before:
After