add haveDependenciesThat condition to ArchConditions#1580
Open
wakingrufus wants to merge 1 commit intoTNG:mainfrom
Open
add haveDependenciesThat condition to ArchConditions#1580wakingrufus wants to merge 1 commit intoTNG:mainfrom
wakingrufus wants to merge 1 commit intoTNG:mainfrom
Conversation
wakingrufus
force-pushed
the
haveDependenciesThat
branch
from
d66d740 to
1593ed1
Compare
Signed-off-by: John Burns <wakingrufus@gmail.com>
wakingrufus
force-pushed
the
haveDependenciesThat
branch
from
1593ed1 to
75d0251
Compare
Author
|
Thanks! I rebased. Just need approval for workflows |
hankem
reviewed
Apr 29, 2026
| quote(CallingClass.class.getName()), quote(SomeClass.class.getName()))); | ||
|
|
||
| assertThat(haveAnyDependenciesThat(DescribedPredicate.<Dependency>alwaysTrue().as("custom"))) | ||
| .hasDescription("have dependencies that custom") |
Member
There was a problem hiding this comment.
Whoopsie. 😉
Suggested change
| .hasDescription("have dependencies that custom") | |
| .hasDescription("have any dependencies that custom") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is not a good way to craft such a condition with current Public APIs
the use case I want this for is:
where
resideInSamePackage()is a DescribedPredicate which requires comparing the target and the owner in the same condition