feat(db): allow externally-provided previousValue in sync update chan…#1445
Open
SamJB123 wants to merge 2 commits intoTanStack:mainfrom
Open
feat(db): allow externally-provided previousValue in sync update chan…#1445SamJB123 wants to merge 2 commits intoTanStack:mainfrom
SamJB123 wants to merge 2 commits intoTanStack:mainfrom
Conversation
…ge detection When collection values are live-reading proxy objects (e.g. Yjs v14 Y.Type proxies via getAttr()), deepEquals(previousVisibleValue, newVisibleValue) always returns true — both sides read through the already-mutated proxy and see identical current values. First updates on proxy-backed rows are silently dropped. ChangeMessage already has an optional previousValue field, and sync sources like Yjs deltas already know the pre-mutation state (SetAttrOp.prevValue). This change lets commitPendingTransactions use sync-provided previousValue for the comparison instead of the captured currentVisibleState, which is unreadable when the value is a live proxy. When previousValue is not provided, behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This change allows consumers the option of providing direct previousValue inputs, improving integration with other sync engines such as Yjs v14, without affecting standard behavior.
When collection values are live-reading proxy objects (e.g. Yjs Y.Type proxies via getAttr()), deepEquals(previousVisibleValue, newVisibleValue) always returns true — both sides read through the already-mutated proxy and see identical current values. First updates on proxy-backed rows are silently dropped.
ChangeMessage already has an optional previousValue field, and sync sources like Yjs deltas already know the pre-mutation state (SetAttrOp.prevValue). This change lets commitPendingTransactions use a sync-provided previousValue for the comparison instead of the captured currentVisibleState, which is unreadable when the value is a live proxy.
When previousValue is not provided, behavior is unchanged.
✅ Checklist
pnpm test.🚀 Release Impact