test(eslint-plugin-query/stable-query-client): fix misleading test name for async component with 'solid-query' import by sukvvon · Pull Request #10344 · TanStack/query

sukvvon · 2026-03-28T06:59:54Z

🎯 Changes

Fix misleading test name for the async component case that uses @tanstack/solid-query import. The previous name 'QueryClient is invoked in an async (react server) component' implied it was testing the React Server Component branch (isReactServerComponent), but it actually returns early at the import check since it uses @tanstack/solid-query instead of @tanstack/react-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved test description clarity for the ESLint plugin.

…me for async component with 'solid-query' import

coderabbitai · 2026-03-28T07:00:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 27478428-4eb7-4bbc-a9e8-6c7f52892efa

📥 Commits

Reviewing files that changed from the base of the PR and between 4225926 and da4ad8a.

📒 Files selected for processing (1)

packages/eslint-plugin-query/src/__tests__/stable-query-client.test.ts

📝 Walkthrough

Walkthrough

A test case label in the eslint-plugin-query test suite was updated to more accurately describe the test's purpose. The new description clarifies that it validates QueryClient is not flagged when imported from a non-react-query package in an async component context.

Changes

Cohort / File(s)	Summary
Test Label Update `packages/eslint-plugin-query/src/__tests__/stable-query-client.test.ts`	Updated test case name string to more accurately reflect the test scenario and expected rule behavior regarding imports from non-react-query packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A label refined, oh what a sight,
The test case now reads crisp and bright,
QueryClient imports, no longer unclear,
A tiny fix, but we hold it dear! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing a misleading test name in the eslint-plugin-query stable-query-client test case.
Description check	✅ Passed	The description follows the required template with all key sections completed: Changes clearly explained, Checklist items marked, and Release Impact properly addressed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/eslint-plugin-query-stable-query-client-fix-misleading-test-name

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-28T07:00:24Z

View your CI Pipeline Execution ↗ for commit da4ad8a

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	43s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-28 07:01:49 UTC

github-actions · 2026-03-28T07:00:39Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-03-28T07:01:30Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10344

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10344

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10344

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10344

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10344

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10344

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10344

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10344

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10344

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10344

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10344

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10344

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10344

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10344

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10344

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10344

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10344

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10344

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10344

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10344

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10344

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10344

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10344

commit: da4ad8a

github-actions · 2026-03-28T07:01:40Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test(eslint-plugin-query/stable-query-client): fix misleading test na…

da4ad8a

…me for async component with 'solid-query' import

github-actions bot added the package: eslint-plugin-query label Mar 28, 2026

sukvvon merged commit 0e766f2 into main Mar 28, 2026
10 checks passed

sukvvon deleted the test/eslint-plugin-query-stable-query-client-fix-misleading-test-name branch March 28, 2026 07:19

sukvvon self-assigned this Mar 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(eslint-plugin-query/stable-query-client): fix misleading test name for async component with 'solid-query' import#10344

test(eslint-plugin-query/stable-query-client): fix misleading test name for async component with 'solid-query' import#10344
sukvvon merged 1 commit intomainfrom
test/eslint-plugin-query-stable-query-client-fix-misleading-test-name

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

pkg-pr-new bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 28, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

nx-cloud bot commented Mar 28, 2026 •

edited

Loading