test({react,preact}-query/useSuspenseQueries): add test for not suspending but only refetching the stale query when one query has fresh and the other has stale cached data by sukvvon · Pull Request #10345 · TanStack/query

sukvvon · 2026-03-28T07:56:25Z

🎯 Changes

Add test for the mixed cache state (fresh + stale) scenario in useSuspenseQueries. Verifies that when one query has fresh cached data and the other has stale cached data:

Neither query triggers a suspend
Only the stale query performs a background refetch
The fresh query is never refetched

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded test coverage for useSuspenseQueries to verify correct behavior when queries have different freshness states at mount, ensuring stale queries refresh in the background without affecting fresh queries.

…nding but only refetching the stale query when one query has fresh and the other has stale cached data

nx-cloud · 2026-03-28T07:56:52Z

View your CI Pipeline Execution ↗ for commit 219ffcb

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-28 08:00:24 UTC

github-actions · 2026-03-28T07:57:15Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-03-28T07:58:36Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10345

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10345

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10345

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10345

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10345

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10345

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10345

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10345

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10345

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10345

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10345

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10345

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10345

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10345

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10345

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10345

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10345

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10345

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10345

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10345

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10345

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10345

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10345

commit: 219ffcb

github-actions · 2026-03-28T07:58:46Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

coderabbitai · 2026-03-28T07:59:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0cf00eed-8a78-452e-9390-b3e9f2d7097e

📥 Commits

Reviewing files that changed from the base of the PR and between 0e766f2 and 219ffcb.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
packages/react-query/src/__tests__/useSuspenseQueries.test.tsx

📝 Walkthrough

Walkthrough

This PR adds identical test cases to both react-query and preact-query test suites that verify useSuspenseQueries behavior when queries have mixed freshness states at mount: one stale query triggers background refetch while one fresh query remains unchanged and does not trigger its query function.

Changes

Cohort / File(s)	Summary
useSuspenseQueries Test Cases `packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx`, `packages/react-query/src/__tests__/useSuspenseQueries.test.tsx`	Added test case verifying that when two queries have different freshness states, the stale query background-refetches while the fresh query remains untouched, and initial render does not suspend showing both cached results.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test(react-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data #10126: Adds useSuspenseQueries tests exercising mixed cached vs pending query behavior with suspension logic.
test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data #10133: Adds closely related useSuspenseQueries tests verifying components don't suspend for cached data while pending/stale queries trigger refetches.
test(preact-query/useSuspenseQueries): align cached data test with react-query to verify background refetch #10195: Modifies useSuspenseQueries tests to verify background refetch behavior and timing differences between cached and stale queries.

Suggested reviewers

TkDodo

Poem

🐰 Queries both fresh and stale
Dance through the cache's tale
One refetches with grace
While one stays in its place
Tests verify the whole travail ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a test for the mixed cache state scenario (fresh + stale) in useSuspenseQueries.
Description check	✅ Passed	The description covers all required template sections: Changes section explains the test purpose and verifications, Checklist items are completed, and Release Impact is properly marked as dev-only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/useSuspenseQueries-fresh-stale-mixed-cache

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

test({react,preact}-query/useSuspenseQueries): add test for not suspe…

219ffcb

…nding but only refetching the stale query when one query has fresh and the other has stale cached data

github-actions bot added package: react-query package: preact-query labels Mar 28, 2026

sukvvon self-assigned this Mar 28, 2026

sukvvon merged commit 7fc6e6a into main Mar 28, 2026
10 checks passed

sukvvon deleted the test/useSuspenseQueries-fresh-stale-mixed-cache branch March 28, 2026 08:07

sukvvon mentioned this pull request Mar 29, 2026

test({react,preact}-query/useSuspenseQueries): add test for not suspending but only refetching the stale query when one query has stale and the other has fresh cached data #10349

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({react,preact}-query/useSuspenseQueries): add test for not suspending but only refetching the stale query when one query has fresh and the other has stale cached data#10345

test({react,preact}-query/useSuspenseQueries): add test for not suspending but only refetching the stale query when one query has fresh and the other has stale cached data#10345
sukvvon merged 1 commit intomainfrom
test/useSuspenseQueries-fresh-stale-mixed-cache

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

nx-cloud bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

pkg-pr-new bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

Uh oh!

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 28, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Mar 28, 2026

Uh oh!

github-actions bot commented Mar 28, 2026

size-limit report 📦

Uh oh!

coderabbitai bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

nx-cloud bot commented Mar 28, 2026 •

edited

Loading

coderabbitai bot commented Mar 28, 2026 •

edited

Loading