test(preact-query): apply 'prefer-template', 'no-else-return', 'object-shorthand', 'radix', and 'require-await' eslint rules by sukvvon · Pull Request #10346 · TanStack/query

sukvvon · 2026-03-28T12:50:01Z

🎯 Changes

Apply eslint-config-preact rules to test files to resolve ESLint warnings:

prefer-template: replace string concatenation with template literals
no-else-return: remove unnecessary else after return
object-shorthand: use shorthand property syntax
radix: add explicit radix parameter to parseInt calls
@typescript-eslint/require-await: remove unnecessary async keyword from queryFn without await
Remove unused eslint-disable directive

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated test utilities across multiple test suites to use template literals instead of string concatenation for improved code consistency and readability.
- Enhanced test specifications with explicit parameter values and simplified conditional logic for better test maintainability.

…t-shorthand', 'radix', and 'require-await' eslint rules

coderabbitai · 2026-03-28T12:50:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7314b1a1-d0ce-44e9-8c24-77ea75c3a60f

📥 Commits

Reviewing files that changed from the base of the PR and between 0e939ac and 468d906.

📒 Files selected for processing (6)

packages/preact-query/src/__tests__/useMutationState.test.tsx
packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx
packages/preact-query/src/__tests__/useQueries.test.tsx
packages/preact-query/src/__tests__/useQuery.test.tsx
packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx

💤 Files with no reviewable changes (1)

packages/preact-query/src/tests/useSuspenseQuery.test.tsx

📝 Walkthrough

Walkthrough

Test files across the preact-query package are modernized to use template literals instead of string concatenation in query functions and assertions. Minor adjustments include explicit radix parameters in parseInt calls and simplified conditional logic. All changes remain confined to test files with no impact on public APIs.

Changes

Cohort / File(s)	Summary
String Formatting Modernization `packages/preact-query/src/__tests__/useMutationState.test.tsx`, `packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx`, `packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx`, `packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx`	Updated string construction in test query functions from concatenation to template literals (e.g., `'data' + input` → `data${input}`). Removed unnecessary eslint-disable directive in one test.
Query Function & Assertion Refactoring `packages/preact-query/src/__tests__/useQueries.test.tsx`	Converted string concatenation to template literals across multiple test cases; added explicit radix parameter (`10`) to `parseInt()` calls throughout test selectors.
Query Function & Assertion Refactoring `packages/preact-query/src/__tests__/useQuery.test.tsx`	Replaced string concatenation with template literals in multiple `queryFn` return values; simplified conditional logic by removing redundant `else` branches; adjusted one `queryFn` from `async` to synchronous while preserving return values; updated error assertion shorthand syntax.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Whiskers twitch with template cheer,
Backticks dancing, oh so dear!
Concatenation's gone away,
Strings interpolate with flair today—
Tests now shimmer, bright and clean! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objective: applying multiple ESLint rules to test files in the preact-query package.
Description check	✅ Passed	The description fully covers the changes made, includes detailed explanations of each ESLint rule applied, and completes all required checklist items with proper release impact designation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/preact-query-fix-eslint-warnings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-28T12:50:28Z

View your CI Pipeline Execution ↗ for commit 468d906

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 33s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-28 12:55:29 UTC

github-actions · 2026-03-28T12:50:44Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-03-28T12:51:56Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10346

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10346

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10346

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10346

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10346

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10346

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10346

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10346

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10346

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10346

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10346

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10346

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10346

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10346

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10346

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10346

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10346

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10346

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10346

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10346

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10346

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10346

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10346

commit: 468d906

github-actions · 2026-03-28T12:52:04Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test(preact-query): apply 'prefer-template', 'no-else-return', 'objec…

fc62e1a

…t-shorthand', 'radix', and 'require-await' eslint rules

github-actions bot added the package: preact-query label Mar 28, 2026

Merge branch 'main' into test/preact-query-fix-eslint-warnings

468d906

sukvvon merged commit a62f695 into main Mar 28, 2026
8 checks passed

sukvvon deleted the test/preact-query-fix-eslint-warnings branch March 28, 2026 13:16

sukvvon self-assigned this Mar 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(preact-query): apply 'prefer-template', 'no-else-return', 'object-shorthand', 'radix', and 'require-await' eslint rules#10346

test(preact-query): apply 'prefer-template', 'no-else-return', 'object-shorthand', 'radix', and 'require-await' eslint rules#10346
sukvvon merged 2 commits intomainfrom
test/preact-query-fix-eslint-warnings

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 28, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 28, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

nx-cloud bot commented Mar 28, 2026 •

edited

Loading

github-actions bot commented Mar 28, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 28, 2026 •

edited

Loading

github-actions bot commented Mar 28, 2026 •

edited

Loading