Skip to content

fix vite preview streaming #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huseeiin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix vite preview streaming #6828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
264d9c4
fix vite preview streaming
huseeiin Mar 5, 2026
9b0aee4
fix
huseeiin Mar 15, 2026
5ca69c1
add changeset
huseeiin Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thick-lines-follow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/start-plugin-core': minor
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use a patch bump for this bug-fix changeset.

Line 2 currently marks @tanstack/start-plugin-core as minor, but this PR is scoped as a fix. This should be patch to keep release semantics accurate.

Suggested change 
-'@tanstack/start-plugin-core': minor
+'@tanstack/start-plugin-core': patch
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'@tanstack/start-plugin-core': minor
'@tanstack/start-plugin-core': patch
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.changeset/thick-lines-follow.md at line 2, The changeset incorrectly marks
'@tanstack/start-plugin-core' as minor; update the entry in
.changeset/thick-lines-follow.md to use a patch bump instead of minor by
replacing "minor" with "patch" for the '@tanstack/start-plugin-core' line so the
changeset reflects this fix-level release.

---

fix streaming in vite preview
4 changes: 4 additions & 0 deletions packages/start-plugin-core/src/preview-server-plugin/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export function previewServerPlugin(): Plugin {
const webReq = new NodeRequest({ req, res })
const webRes: Response = await serverBuild.fetch(webReq)

if (webRes.headers.get('content-type')?.startsWith('text/html')) {
res.setHeader('content-encoding', 'identity')
}

// Temporary workaround
// Vite preview's compression middleware doesn't support flattened array headers that srvx sets
// Call writeHead() before srvx to avoid corruption
Expand Down
Loading