Skip to content

[0.3.6 TASK 3469] Fixed Issue with FIFA dataset validation - "null"#58

Merged
sujata-m merged 22 commits intodevelopfrom
feature-3469
Apr 10, 2026
Merged

[0.3.6 TASK 3469] Fixed Issue with FIFA dataset validation - "null"#58
sujata-m merged 22 commits intodevelopfrom
feature-3469

Conversation

@sujata-m
Copy link
Copy Markdown
Contributor

@sujata-m sujata-m commented Apr 10, 2026

Dev Board Ticket

https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3469

Changes

PR Title
Add task_3469 regression test, align jsonschema_rs pin to 0.33.0, and bump version to 0.3.6

PR Summary

  • Added a regression test for tests/assets/task_3469.zip to assert the exact issues payload:
    • {'filename': 'FIFA_sidewalks.edges.geojson', 'feature_index': 0, 'error_message': ['"null" is not one of "down" or "up"']}
  • Added a unit test to enforce jsonschema_rs==0.33.0 pin consistency between requirements.txt and setup.py.
  • Updated setup.py dependency pin from jsonschema_rs==0.26.1 to 0.33.0.
  • Bumped package version from 0.3.5 to 0.3.6.
  • Updated CHANGELOG.md with a 0.3.6 - 2026-04-10 release entry.

Testing

  • Ran:
    • .venv/bin/python -m unittest -v tests.unit_tests.test_osw_validation.TestOSWValidation.test_task_3469_issue_payload tests.unit_tests.test_osw_validation.TestOSWValidation.test_jsonschema_rs_pin_is_0_33_0
  • Result: both tests passed.

sujata-m and others added 22 commits July 3, 2024 18:49
Develop to Main for version 0.2.2
Develop to Main for version 0.2.3
[0.3.2] Updated unit test cases
[0.3.3] Fixed Task-2817 & Issue-2844
## Dev Board Ticket

https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3469

## Changes
**PR Title**
`Add task_3469 regression test, align jsonschema_rs pin to 0.33.0, and bump version to 0.3.6`

**PR Summary**
- Added a regression test for `tests/assets/task_3469.zip` to assert the exact `issues` payload:
  - `{'filename': 'FIFA_sidewalks.edges.geojson', 'feature_index': 0, 'error_message': ['"null" is not one of "down" or "up"']}`
- Added a unit test to enforce `jsonschema_rs==0.33.0` pin consistency between `requirements.txt` and `setup.py`.
- Updated `setup.py` dependency pin from `jsonschema_rs==0.26.1` to `0.33.0`.
- Bumped package version from `0.3.5` to `0.3.6`.
- Updated `CHANGELOG.md` with a `0.3.6 - 2026-04-10` release entry.

## Testing
- Ran:
  - `.venv/bin/python -m unittest -v tests.unit_tests.test_osw_validation.TestOSWValidation.test_task_3469_issue_payload tests.unit_tests.test_osw_validation.TestOSWValidation.test_jsonschema_rs_pin_is_0_33_0`
- Result: both tests passed.
@sujata-m sujata-m changed the title Feature 3469 [0.3.6 TASK 3469] Fixed Issue with FIFA dataset validation - "null" Apr 10, 2026
@sujata-m sujata-m requested review from MashB and susrisha April 10, 2026 10:30
@sujata-m sujata-m merged commit 04aae2e into develop Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants