Conversation
## Dev Board Ticket https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3469 ## Changes **PR Title** `Add task_3469 regression test, align jsonschema_rs pin to 0.33.0, and bump version to 0.3.6` **PR Summary** - Added a regression test for `tests/assets/task_3469.zip` to assert the exact `issues` payload: - `{'filename': 'FIFA_sidewalks.edges.geojson', 'feature_index': 0, 'error_message': ['"null" is not one of "down" or "up"']}` - Added a unit test to enforce `jsonschema_rs==0.33.0` pin consistency between `requirements.txt` and `setup.py`. - Updated `setup.py` dependency pin from `jsonschema_rs==0.26.1` to `0.33.0`. - Bumped package version from `0.3.5` to `0.3.6`. - Updated `CHANGELOG.md` with a `0.3.6 - 2026-04-10` release entry. ## Testing - Ran: - `.venv/bin/python -m unittest -v tests.unit_tests.test_osw_validation.TestOSWValidation.test_task_3469_issue_payload tests.unit_tests.test_osw_validation.TestOSWValidation.test_jsonschema_rs_pin_is_0_33_0` - Result: both tests passed.
[0.3.6 TASK 3469] Fixed Issue with FIFA dataset validation - "null"
MashB
approved these changes
Apr 10, 2026
susrisha
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3469
Changes
tests/assets/task_3469.zipto assert the exactissuespayload:{'filename': 'FIFA_sidewalks.edges.geojson', 'feature_index': 0, 'error_message': ['"null" is not one of "down" or "up"']}jsonschema_rs==0.33.0pin consistency betweenrequirements.txtandsetup.py.setup.pydependency pin fromjsonschema_rs==0.26.1to0.33.0.0.3.5to0.3.6.CHANGELOG.mdwith a0.3.6 - 2026-04-10release entry.Testing
.venv/bin/python -m unittest -v tests.unit_tests.test_osw_validation.TestOSWValidation.test_task_3469_issue_payload tests.unit_tests.test_osw_validation.TestOSWValidation.test_jsonschema_rs_pin_is_0_33_0