Skip to content

Vision Code#19

Merged
PillageDev merged 8 commits intodevelopfrom
17-vision
Feb 27, 2026
Merged

Vision Code#19
PillageDev merged 8 commits intodevelopfrom
17-vision

Conversation

@PillageDev
Copy link
Copy Markdown
Member

@PillageDev PillageDev commented Feb 20, 2026

Adds vision code for the robot

  • 2 cameras (with the ability to add more in the list)
  • Kalman filter for positions (scales with distance to tag)
  • Validation checks for ambiguity

Closes #17

@PillageDev PillageDev requested review from a team February 20, 2026 02:37
@PillageDev PillageDev linked an issue Feb 20, 2026 that may be closed by this pull request
Vision #17
Closed
NathanEdg
NathanEdg previously approved these changes Feb 20, 2026
View reviewed changes
bjmcternan
bjmcternan reviewed Feb 20, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/generated/TunerConstants.java Outdated
bjmcternan
bjmcternan reviewed Feb 20, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/vision/photon/Camera.java
bjmcternan
bjmcternan previously requested changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bjmcternan bjmcternan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too bad. Please add comments so we can better understand what this does.

realtrev
realtrev previously approved these changes Feb 20, 2026
View reviewed changes
@PillageDev PillageDev dismissed stale reviews from realtrev and NathanEdg via 9431f9f February 22, 2026 17:51
NathanEdg
NathanEdg previously approved these changes Feb 22, 2026
View reviewed changes
afranchuk
afranchuk previously approved these changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown

@afranchuk afranchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start overall!

Comment thread src/main/java/frc/robot/subsystems/drive/CommandSwerveDrivetrain.java
Comment thread src/main/java/frc/robot/subsystems/vision/photon/Camera.java Outdated
Comment thread src/main/java/frc/robot/subsystems/vision/Vision.java
@PillageDev PillageDev requested a review from NathanEdg February 27, 2026 17:38
bjmcternan
bjmcternan approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bjmcternan bjmcternan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PillageDev PillageDev merged commit aa86ee1 into develop Feb 27, 2026
2 checks passed
@PillageDev PillageDev deleted the 17-vision branch February 27, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjmcternan bjmcternan bjmcternan approved these changes

@NathanEdg NathanEdg NathanEdg approved these changes

@afranchuk afranchuk Awaiting requested review from afranchuk

@realtrev realtrev Awaiting requested review from realtrev

@maxim-kudryashov maxim-kudryashov Awaiting requested review from maxim-kudryashov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vision

6 participants

@PillageDev @afranchuk @bjmcternan @realtrev @maxim-kudryashov @NathanEdg