Open
Conversation
mini-min
added
Minjae 🐻❄️
hyun99999
reviewed
Mar 31, 2024
Member
hyun99999
left a comment
hyun99999
left a comment
There was a problem hiding this comment.
SPM 으로 관리하는 방법 좋은 것 같아요! 그런데 SPM 에서 지원하지 않는 것들이 꽤나 많아서 선별해서 전환해야 할 것 같습니다...!! alamofire 만 우선 변경하실 건가요? 지금 커밋 내역에는 해당 기록이 없는데 확인할 수 있을까용?
| // Configuration settings file format documentation can be found at: | ||
| // https://help.apple.com/xcode/#/dev745c5c974 | ||
|
|
||
| #include "Pods/Target Support Files/Pods-NADA-iOS-forRelease/Pods-NADA-iOS-forRelease.debug.xcconfig" |
Member
There was a problem hiding this comment.
나머지 cocoapods 에서 제공하는 프레임워크는 필요할텐데 이렇게 삭제 해도 괜찮나용?
hyun99999
reviewed
Mar 31, 2024
dlwns33
approved these changes
Apr 2, 2024
Member
dlwns33
left a comment
dlwns33
left a comment
There was a problem hiding this comment.
남아있던 코드들을 지우니 한층 프로젝트가 깔끔해진 것 같아요!
사실 오래된 프로젝트들의 문제점 중 하나가 레거시 코드가 많이 있다는 점인데,
이렇게 새로운게 생길때마다 프로젝트 정리를 한번씩 해주면 레거시 코드들이 남아있지 않아서 좋은 것 같네요~ 하나하나 고치느라 진짜 수고했담!
Comment on lines
+602
to
+608
| self.timesLeft = 600 - (interval.second ?? 0) | ||
| print("✅ now: ", Date()) | ||
| print("✅ activated Time: ", nearByUUIDResponse.activeTime?.toDate()) | ||
| print("✅ timesleft: ", self.timesLeft) | ||
| self.nearByTimeLabel.text = "" | ||
| self.setCardActivationUI(with: nearByUUIDResponse.isActive, secondsLeft: self.timesLeft ?? 0) | ||
| self.setCardActivationUI(with: nearByUUIDResponse.isActive, | ||
| secondsLeft: self.timesLeft) |
Member
There was a problem hiding this comment.
제가 요 부분을 개발했을때 굉장히 급하게 개발했던 것으로 기억합니다...
저 이니셜 값이 없어도 잘 돌아가던가요..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
제대 후 나다에서 처음 날리는 PR이네요.....설렙니다.
용량 줄이기 작업이 너무 무거워져서 쪼개려고 먼저 PR 올립니다!
1. 에셋 정리
2. 패키지 관리 방법 변경 (Cocoapods -> SPM)
이후에 어떤 작업?
📮 관련 이슈