CHAT-53: Fixes to improve error messages from cloudflare.#55
Open
CHAT-53: Fixes to improve error messages from cloudflare.#55
Conversation
Flanderzz
requested changes
Feb 19, 2025
Collaborator
Flanderzz
left a comment
Flanderzz
left a comment
There was a problem hiding this comment.
fix these and this should be good
|
|
||
| } catch (ProfileImageException e) { | ||
| log.warn("File type not accepted: {}", request.getFile().getContentType()); | ||
| return buildErrorResponse(HttpStatus.UNSUPPORTED_MEDIA_TYPE, "Profile picture type is not allowed!", "/signup"); |
Collaborator
There was a problem hiding this comment.
For this part, we have a global exception handler, and they get propagated from there as errors. i would move these or add the error handling to there.
| } catch (Exception e) { | ||
| log.error("Unexpected error during signup process", e); | ||
| throw new UserException("Unexpected error during signup process"); | ||
| return buildErrorResponse(HttpStatus.INTERNAL_SERVER_ERROR, "Unexpected error during signup process", "/signup"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get very nice error messages. Throw less exceptions and make the client very happy.
