Skip to content

update both target and compile skd to api 35 #ANDROID-15972#22

Merged
juangardi21 merged 2 commits intomainfrom
task/ANDROID-15972-android-15
Apr 8, 2025
Merged

update both target and compile skd to api 35 #ANDROID-15972#22
juangardi21 merged 2 commits intomainfrom
task/ANDROID-15972-android-15

Conversation

@juangardi21
Copy link
Contributor

@juangardi21 juangardi21 commented Apr 3, 2025

🎟️ Jira tickets

Task SMARTWIFI-11422

🥅 What's the goal?

Update both target and compile sdk to android 35.

🚧 How do we do it?

  • Adding enableEdgeToEdge method to the activities
  • Fix the overlapping with the system bars

📘 Documentation changes?

  • No docs to update nor create

🧪 How can I test this?

Before After
Before
Grabacion.de.pantalla.2025-04-03.a.las.15.13.17.mov

}

dependencies {
implementation libs.androidx.activity
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for enableEdgeToEdge method


private fun toggleCategoryFilter() {
if (filtersView.visibility == View.VISIBLE) {
if (filtersView.isVisible) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a warning

}

internal fun <From, To> LiveData<From>.map(mapFunc: (From) -> To): LiveData<To> =
Transformations.map(this, mapFunc) No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used in new versions

else -> super.onOptionsItemSelected(item)
}

override fun onBackPressed() {
Copy link
Contributor Author

@juangardi21 juangardi21 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is deprecated. I've replaced it by the new way of going back

@juangardi21 juangardi21 requested review from a team, dpastor and jdelga and removed request for a team April 3, 2025 13:25
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Copy link
Member

@jdelga jdelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@juangardi21 juangardi21 merged commit 3d3a55c into main Apr 8, 2025
1 check passed
@juangardi21 juangardi21 deleted the task/ANDROID-15972-android-15 branch April 8, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants