Skip to content

feat: support overrideHost configuration for ratelimit, event reporter and stat modules#1804

Merged
SkyeBeFreeman merged 2 commits intoTencent:2024from
SkyeBeFreeman:feat/override-host
Apr 9, 2026
Merged

feat: support overrideHost configuration for ratelimit, event reporter and stat modules#1804
SkyeBeFreeman merged 2 commits intoTencent:2024from
SkyeBeFreeman:feat/override-host

Conversation

@SkyeBeFreeman
Copy link
Copy Markdown
Collaborator

Summary

  • Add limiterOverrideHost property to PolarisRateLimitProperties for overriding remote rate limiter service host
  • Add overrideHost property to PushGatewayEventReporterProperties for overriding push gateway event reporter host
  • Add pushGatewayOverrideHost property to PolarisStatProperties for overriding Prometheus push gateway host
  • All three properties allow replacing discovered instance IPs with a specified host while preserving original ports
  • Updated corresponding ConfigModifier classes to propagate the new settings to polaris-java SDK
  • Added unit tests for all new properties and config modifiers

Test plan

  • Unit tests added for PolarisRateLimitProperties, RateLimitConfigModifier
  • Unit tests added for PushGatewayEventReporterProperties, PushGatewayEventReporterConfigModifier
  • Unit tests added for PolarisStatProperties, StatConfigModifier
  • Run full CI (JUnit + Checkstyle + License Header)

🤖 Generated with Claude Code

SkyeBeFreeman added a commit to SkyeBeFreeman/spring-cloud-tencent that referenced this pull request Apr 8, 2026
Signed-off-by: Haotian Zhang <928016560@qq.com>
@SkyeBeFreeman SkyeBeFreeman requested a review from fuyuwei01 April 8, 2026 11:46
Copy link
Copy Markdown
Collaborator

@fuyuwei01 fuyuwei01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.64%. Comparing base (fe5a32b) to head (2a03be2).
⚠️ Report is 1 commits behind head on 2024.

Files with missing lines Patch % Lines
...enhancement/stat/config/PolarisStatProperties.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2024    #1804      +/-   ##
============================================
+ Coverage     54.62%   54.64%   +0.02%     
  Complexity      152      152              
============================================
  Files           482      482              
  Lines         14089    14101      +12     
  Branches       1765     1765              
============================================
+ Hits           7696     7706      +10     
- Misses         5776     5778       +2     
  Partials        617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SkyeBeFreeman and others added 2 commits April 9, 2026 10:01
…r and stat modules

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Haotian Zhang <928016560@qq.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Haotian Zhang <928016560@qq.com>
@SkyeBeFreeman SkyeBeFreeman merged commit 68253fd into Tencent:2024 Apr 9, 2026
7 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the feat/override-host branch April 9, 2026 02:13
SkyeBeFreeman added a commit that referenced this pull request Apr 9, 2026
…r and stat modules (#1804)

Signed-off-by: Haotian Zhang <928016560@qq.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SkyeBeFreeman added a commit that referenced this pull request Apr 9, 2026
…r and stat modules (#1804)

Signed-off-by: Haotian Zhang <928016560@qq.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants