Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables the default “thinking” behavior in the Gemini flash integration by introducing a zero-budget branch and updating how streamed chunks are handled.
- Split
thinkingConfiginto a high-budget branch (whenthink?is true) and a zero-budget branch (when false) - Replaced the previous
swap!accumulation with a debugconsole.logand aneitherfallback on streamed text - Propagated the same changes into the
calcit.cirruAST representation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| compact.cirru | Updated thinkingConfig instantiation and replaced chunk accumulation with debug log + either |
| calcit.cirru | Mirrored the new thinkingConfig branches and debug/log + either logic in the AST diff |
Comments suppressed due to low confidence (5)
compact.cirru:258
- The code now emits two consecutive
js-objectcalls under:thinkingConfigwithout conditional logic tying them together. You likely intended to use aniforcondto choose one object instead of listing both unconditionally.
js-object (:thinkingBudget 1000) (:includeThoughts think?) js-object (:thinkingBudget 0) (:includeThoughts false)
compact.cirru:283
- [nitpick] This
console.logappears to be a debug statement. Consider removing or gating it behind a debug flag.
do (js/console.log "With think" chunk)
compact.cirru:284
- Referencing
js/chunk.candidatesis incorrect — you should accesschunk.candidates[0]directly, not via ajs/prefix.
swap! *text str $ either (.-text chunk) js/chunk.candidates[0].content.parts[0].text
calcit.cirru:2078
- [nitpick] This AST fragment introduces a
js/console.logcall. If it’s intended only for debugging, consider removing it from production code.
|X $ %{} :Expr (:at 1748538740807) (:by |rJG4IHzWf)
calcit.cirru:2093
- The
eithercall is using.-textand thenchunk.candidatesviajs/...; these references should consistently access the same object (e.g.,chunk) without mixing prefixes.
|T $ %{} :Leaf (:at 1748538835014) (:by |rJG4IHzWf) (:text |.-text)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.