fix: enable AUTHOR_TESTING in macOS CI workflow#1069
Draft
Koan-Bot wants to merge 2 commits intoTest-More:masterfrom
Draft
fix: enable AUTHOR_TESTING in macOS CI workflow#1069Koan-Bot wants to merge 2 commits intoTest-More:masterfrom
Koan-Bot wants to merge 2 commits intoTest-More:masterfrom
Conversation
The appveyor.yml file contains an encrypted Slack notification token, uses a Dist::Zilla build workflow inconsistent with the Makefile.PL approach used in the GitHub Actions CI, and targets a CI service no longer actively used for this project (AppVeyor). Windows CI is now handled by the windows.yml GitHub Actions workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AUTHOR_TESTING was set to 0 in the macOS workflow while Linux and Windows both had it set to 1. This caused author-level tests (thread safety, regression tests) to be silently skipped on macOS, reducing CI coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set
AUTHOR_TESTINGfrom0to1in.github/workflows/macos.yml.Why
Linux and Windows CI workflows both have
AUTHOR_TESTING: 1, but macOS had it set to0. This meant author-level tests (thread safety tests, regression tests guarded byAUTHOR_TESTING) were silently skipped on macOS — reducing CI coverage for a platform with distinct threading and signal behavior.How
One-character change:
0→1on line 18.Testing
Verified all three workflows now have consistent
AUTHOR_TESTING: 1.🤖 Generated with Claude Code