Fix awkward event dates spanning multiple months#241
Open
DanWillman wants to merge 2 commits intoThatConference:mainfrom
Open
Fix awkward event dates spanning multiple months#241DanWillman wants to merge 2 commits intoThatConference:mainfrom
DanWillman wants to merge 2 commits intoThatConference:mainfrom
Conversation
|
@DanWillman is attempting to deploy a commit to the That Conference Team on Vercel. A member of the Team first needs to authorize it. |
AgentEnder
reviewed
May 6, 2024
Comment on lines
+24
to
+28
| <span class="text-green-500">{`${venue.city}, ${venue.state}`}</span> / {#if isSameMonthAndYear(event.startDate, event.endDate)} | ||
| {dayjs(event.startDate).format('MMMM Do')} - {dayjs(event.endDate).format('Do, YYYY')} | ||
| {:else} | ||
| {dayjs(event.startDate).format('MMMM Do, YYYY')} - {dayjs(event.endDate).format('MMMM Do, YYYY')} | ||
| {/if} |
There was a problem hiding this comment.
Is it maybe worth pulling this whole block out into either a date range component or a formatDateRange util?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date range is a bit awkward given we end in August this year, this should hopefully fix this. But I'm no svelte expert, so I'm not sure if this is the best approach.