Open
Conversation
BobDotCom
requested changes
Aug 25, 2021
Member
There was a problem hiding this comment.
A couple changes would be good here
- make a general function, maybe like
await check_user(user)and invoke that in each event. This would make the code much shorter
@commands.Cog.listener()
async def on_member_update(self, before, after):
await check_user(after)- in your checks, it would be easier to move this code into general.py and use the check_invite function. It filters links better.
async def check_user(user):
if await check_invite(user.display_name):
# Take action here, user has a bad name
pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anti-bot cog -> Checks for invite links in user's name/nick when they join or update their nickname after joining and kicks them accordingly. Also made it so it will loop thru all the members in the server when the bot is restarted so any members left out while the bot is offline will be kicked instantly.