-
Notifications
You must be signed in to change notification settings - Fork 436
[rsz] Change RSZ-0075 warning to debug + remove pre-placement buffer attempt #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4b2e717
0991b59
90e7bc6
a34ba69
3281738
a3f6840
5db4546
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,7 +130,6 @@ if { !$::env(SKIP_REPAIR_TIE_FANOUT) } { | |
| } | ||
|
|
||
| if { [env_var_exists_and_non_empty SWAP_ARITH_OPERATORS] } { | ||
| log_cmd estimate_parasitics -placement | ||
| replace_arith_modules | ||
| } | ||
|
|
||
|
|
@@ -139,7 +138,7 @@ if { $::env(REMOVE_ABC_BUFFERS) } { | |
| remove_buffers | ||
| } else { | ||
| # Skip clone & split | ||
| repair_timing_helper -setup -skip_last_gasp -sequence "unbuffer,sizeup,swap,buffer,vt_swap" | ||
| repair_timing_helper -setup -skip_last_gasp -sequence "unbuffer,sizeup,swap,vt_swap" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @povik I removed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We remove buffers at 3_2 so any buffering we do at floorplan will be short-lived. Perhaps it's useful to do it anyway to get a more accurate timing report and to guide other resizer operations which look at timing. Matt and I have discussed this a couple of times but never did any changes as it always seemed low priority.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for sharing. @precisionmoon @maliberty Any other thoughts?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it currently does little as most moves abort when there is no placement. If a secure CI confirms I am ok to remove it. The original thought was to use gain-based buffering here.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. Then let's merge this PR after resolving the merge conflict caused by MCMM update. I'll check if the gain-based buffering in floorplan stage is meaningful gain or not, and open a new PR if it shows meaningful gain. |
||
| } | ||
|
|
||
| puts "Default units for flow" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unplaced at this stage.